RFR: 8170544: Fix code scan findings in libnet

[Michael McMahon]

Okay. I'll run the three patches through jprt again

Michael

On 01/12/2016, 11:53, Langer, Christoph wrote:
>
> Hi Michael,
>
> I have just updated 
> http://cr.openjdk.java.net/~clanger/webrevs/8170544.0/ 
> <http://cr.openjdk.java.net/%7Eclanger/webrevs/8170544.0/> in place. 
> The old version caused a compile warning on Linux.
>
> Best regards
>
> Christoph
>
> *From:*Langer, Christoph
> *Sent:* Mittwoch, 30. November 2016 19:01
> *To:* 'Michael McMahon' <michael.x.mcmahon at oracle.com>
> *Cc:* net-dev at openjdk.java.net; Chris Hegarty 
> <chris.hegarty at oracle.com>; Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
> *Subject:* RE: RFR: 8170544: Fix code scan findings in libnet
>
> Thanks, Michael.
>
> Maybe you can run all the 3 together:
>
> http://cr.openjdk.java.net/~clanger/webrevs/8167457.1/ 
> <http://cr.openjdk.java.net/%7Eclanger/webrevs/8167457.1/>
>
> http://cr.openjdk.java.net/~clanger/webrevs/8167420.2/ 
> <http://cr.openjdk.java.net/%7Eclanger/webrevs/8167420.2/>
>
> http://cr.openjdk.java.net/~clanger/webrevs/8170544.0/ 
> <http://cr.openjdk.java.net/%7Eclanger/webrevs/8170544.0/>
>
> 8170544 comes atop 8167420 (though it's just a small clash).
>
> Best regards
>
> Christoph
>
> *From:*Michael McMahon [mailto:michael.x.mcmahon at oracle.com]
> *Sent:* Mittwoch, 30. November 2016 17:57
> *To:* Langer, Christoph <christoph.langer at sap.com 
> <mailto:christoph.langer at sap.com>>
> *Cc:* net-dev at openjdk.java.net <mailto:net-dev at openjdk.java.net>; 
> Chris Hegarty <chris.hegarty at oracle.com 
> <mailto:chris.hegarty at oracle.com>>; Lindenmaier, Goetz 
> <goetz.lindenmaier at sap.com <mailto:goetz.lindenmaier at sap.com>>
> *Subject:* Re: RFR: 8170544: Fix code scan findings in libnet
>
> I will run the change through JPRT Christoph
>
> Thanks
> Michael
>
> On 30/11/2016, 16:32, Langer, Christoph wrote:
>
>     Hi,
>
>     please review the following change:
>
>     Bug: https://bugs.openjdk.java.net/browse/JDK-8170544
>
>     Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8170544.0/
>     <http://cr.openjdk.java.net/%7Eclanger/webrevs/8170544.0/>
>
>     With this change I change some function signatures to use
>     SOCKETADDRESS * instead of struct sockaddr * where appropriate.
>     This fixes some code scan findings, which reported the fact that
>     it's dangerous to pass struct socaddr * pointers and then cast it
>     to the wider struct sockaddr_in6. I think this makes the code
>     cleaner and spares some casts at several places.
>
>     Please review and run through JPRT testing.
>
>     Thanks
>
>     Christoph
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/net-dev/attachments/20161201/179cf708/attachment.html>