RFR (S): 8164057: Fix @since for java.net.Inet[46]Address
Chris Hegarty
chris.hegarty at oracle.com
Wed Dec 7 10:51:45 UTC 2016
Hi Christoph,
> On 7 Dec 2016, at 08:38, Langer, Christoph <christoph.langer at sap.com> wrote:
>
> Hi,
>
> please review this small fix.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8164057
> Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8164057.0/
>
> The root cause of the wrong “@since” tags probably is that the classes Inet[46]Address had been created as copy of InetAddress. InetAddress itself obviously exists since 1.0 and methods have been added over time. The copying of InetAddress towards Inet[46]Adress has been done for Java 1.4 and hence all Javadoc that was tagged @since <1.4 is not correct for the new classes.
I suspect that you’re right. This looks like an oversight during the addition of
these classes in 1.4.
> I suggest to remove all @since <= 1.4 since the classes themselves are annotated “@since 1.4” which would imply all unannotated methods exist from 1.4 onwards. Alternatively we could a) remove only occurences of @since < 1.4 or b) change all @since < 1.4 to @since 1.4.
I think I favour the approach that you have taken in the webrev, remove all
occurrences of @since <= 1.4. This can be considered as a Review, from me.
I will shepherd this through the CCC process and let you know when it is
complete, or if any issues arise.
-Chris.
More information about the net-dev
mailing list