RFR(s): 8170864: java/net/URLClassLoader/closetest/CloseTest.java has undeclared dependensies

[Sergei Kovalev]

Hi Colleagues,

Thank you for review.


>>> Issue: One of networking tests fails in case using a command line 
>>> option "--limit-module".
>>> Root cause: there is undeclared dependency on java.logging.
>> Are you sure of this? The test does not use logging directly, and the 
>> HTTP
>> server no longer uses jdk.util.logging ( it uses the system logger ).
>>
Logging required for logging handler. If I would not include 
java.logging I'll get below exception:

java.lang.NoClassDefFoundError: java/util/logging/Handler
         at CloseTest.startHttpServer(CloseTest.java:158)
         at CloseTest.main(CloseTest.java:67)
         at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native 
Method)
         at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
         at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
         at java.base/java.lang.reflect.Method.invoke(Method.java:538)
         at 
com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:110)
         at java.base/java.lang.Thread.run(Thread.java:844)

that make me sure that java.logging required.
>
> I agree with Chris that is strange. It's possible that loading
> a java.sql class required logging to be present - I believe there's
> a requires transitive java.logging in the sql module.
>
> Now that you have removed that dependency it would be worth checking
> whether java.logging is still required.
>
> Also I am puzzled by:
>   28  * @library ../../../../com/sun/net/httpserver
> I wonder what in this test requires anything from this
> directory which is not a library and only contains httpserver
> tests?
The class FileServerHandler located there.

158        HttpContext ctx = httpServer.createContext (
159               "/", new FileServerHandler(docroot)
160        );
>
> best regards,
>
> -- daniel

-- 
With best regards,
Sergei