RFR (M): 8171077: Use getaddrinfo/getnameinfo in Windows Inet4AddresImpl native code

Chris Hegarty chris.hegarty at oracle.com
Mon Dec 19 19:19:27 UTC 2016


Hi Christoph,
> On 12 Dec 2016, at 10:09, Langer, Christoph <christoph.langer at sap.com> wrote:
> 
> Hi again,
>  
> this is the Windows part.
>  
> Bug: https://bugs.openjdk.java.net/browse/JDK-8171077
> Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8171077.0/

I think this looks ok.

For consistency, should the code ‘goto cleanupAndReturn’ if 
getaddrinfo fails ( rather than release + return ) ?

Out of curiosity were you seeing issues with the older
getXXXbyXXX calls, or is this cleanup/modernisation driven?

-Chris.



More information about the net-dev mailing list