RFR: 8087112 HTTP API and HTTP/1.1 implementation

[Sean Coffey]

Michael,

just a comment from the supportability side of things. I think the 
exception handling can be improved with better exception messages which 
convey state.

e.g
http://cr.openjdk.java.net/~michaelm/8087112/01/jdk/webrev/src/java.httpclient/share/classes/java/net/http/Http1Request.java.html
  319                 if (contentWritten != contentLength) {
  320                     throw new IOException("wrong content length");

Let's print the length value.

  http://cr.openjdk.java.net/~michaelm/8087112/01/jdk/webrev/src/java.httpclient/share/classes/java/net/http/AuthenticationFilter.java.html
  215         } else if (au.retries > retry_limit) {
  216             throw new IOException("too many authentication attempts");

Let's print the retry limit.

http://cr.openjdk.java.net/~michaelm/8087112/01/jdk/webrev/src/java.httpclient/share/classes/java/net/http/Http1Response.java.html
   90         } else {
   91             throw new IOException("Unexpected HTTP protocol version");

Let's print the statusline value in such cases.

These are just some examples. I can help contribute a patch if you want 
or perhaps you can run through and edit in your own repo.

regards,
Sean.

On 04/02/2016 16:14, Michael McMahon wrote:
> Hi,
>
> The following webrevs are for the initial implementation of JEP 110.
> Most of it is in the jdk repository with some build configuration in 
> the top
> level repo for putting this code in its own module (java.httpclient).
>
> http://cr.openjdk.java.net/~michaelm/8087112/01/top/webrev/
>
> http://cr.openjdk.java.net/~michaelm/8087112/01/jdk/webrev/
>
> The HTTP/2 implementation will come later.
>
> Thanks,
> Michael.