RFR 8140472/9, java/net/ipv6tests/TcpTest.java failed intermittently with java.net.BindException: Address already in use

[Felix Yang]

Thanks Chris! I will remove bug id as you suggested.

TO Frank,
     could you sponsor the fix?

Thanks,
Felix

On 2016/1/6 17:56, Chris Hegarty wrote:
> Thank Felix.
>
> On 06/01/16 08:27, Felix Yang wrote:
>> Hi Chris,
>>       updated webrev with your suggestion:
>> http://cr.openjdk.java.net/~xiaofeya/8140472/webrev.01/
>
> These changes look ok to me.
>
> Trivially, I'd drop the addition of the bugId from the @bug tag,
> since the test is not exercising 8140472 ( it is a bug in the
> test itself ).
>
> -Chris.
>
>> Thanks,
>> Felix
>> On 2016/1/6 13:49, Chris Hegarty wrote:
>>> Hi Felix,
>>>
>>> On 6 Jan 2016, at 05:09, Felix Yang <felix.yang at oracle.com> wrote:
>>>
>>>> Hi all,
>>>>     please review the fix for java/net/ipv6tests/TcpTest.java, which
>>>> replaces hard-coded ports with dynamic free ports on runtime.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8140472
>>>> Webrev: http://cr.openjdk.java.net/~xiaofeya/8140472/webrev.00
>>> Ooh, I wasn’t aware that the getFreePort ( open and close a 
>>> ServerSocket
>>> on an ephemeral port quickly, then assume that that ephemeral port is
>>> “available" ) was still in use. It has been shown to be unstable in
>>> other test
>>> areas, namely rmi. I don’t think that we should use it here.
>>>  From my perspective I don’t see that the specific cases that use
>>> hard-coded
>>> ports are all that useful. Maybe they should just be removed, if 
>>> they are
>>> causing problems.
>>>
>>> -Chris.
>>