RFR: 8146686: Create the schemeSpecificPart for non-opaque URIs lazily

Alan Bateman Alan.Bateman at oracle.com
Fri Jan 8 15:34:17 UTC 2016



On 08/01/2016 14:41, Claes Redestad wrote:
> Hi,
>
> please review this patch to lazily create schemeSpecificPart for 
> non-opaque URIs. This change accounts for some improvement in 
> footprint characteristics and a 10-20% improvement on URI creation 
> microbenchmarks, while not regressing notably on a targetted 
> microbenchmark which explicitly generate and retrieve the 
> schemeSpecificPart.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8146686
> Webrev: http://cr.openjdk.java.net/~redestad/8146686/webrev.01/
This looks okay to me. The only thing that I wonder about is the 
original code returning null when getRawSchemeSpecificPart is specified 
to never return null.

-Alan.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/net-dev/attachments/20160108/f95f7cc1/attachment.html>


More information about the net-dev mailing list