RFR [9] 8143554: UnsupportedOperationException is not thrown for unsupported options

Svetlana Nikandrova svetlana.nikandrova at oracle.com
Wed Jan 13 15:48:11 UTC 2016


Alan,

thank you for you replay.
Here is my updated webrev with formatting fixes.
http://cr.openjdk.java.net/~kshefov/8143554/webrev.03/ 
<http://cr.openjdk.java.net/%7Ekshefov/8143554/webrev.03/>

About getSocket() check - you are right, it is because there are Socket 
options unsupported by ServerSocket.

Thank you,
Svetlana

On 30.12.2015 11:15, Alan Bateman wrote:
>
> The update to PlainSocketImpl and PlainDatagramSocketImpl look okay, 
> just a minor nit that "if(" should be "if (" to keep the code consistent.
>
> For SocketImpl then I assume the getSocket() check is because these 
> are Socket rather than ServerSocket options.
>
> There are few formatting issues in the test that would be good to fix 
> up before this is pushed, otherwise the test looks okay to me.
>
> -Alan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/net-dev/attachments/20160113/fe0ccfce/attachment.html>


More information about the net-dev mailing list