RFR JDK-8161091 Incorrect Stream.FlowControl implementation allows to send DataFrame even when window size was exhausted

[Brian Burkhalter]

Hi Sergey,

This is not my area of expertise so probably a second Reviewer would be in order here but the changes appear straightforward.

On Jul 8, 2016, at 2:40 PM, Sergey Kuksenko <sergey.kuksenko at oracle.com> wrote:

> Could you please review the following fix for JDK-8161091?
> 
> http://cr.openjdk.java.net/~skuksenko/jep110/8161091/webrev.00/
> https://bugs.openjdk.java.net/browse/JDK-8161091
> 
> Existing Stream.FlowControl implementation doesn't decrease amount of permits if requested amount is less than permits. That means that client may send any amount of data if data frame size less than window size.

This looks correct.

Also per the HTTP2 specification [1]

"All implementations MUST be capable of receiving and minimally processing frames up to 214 octets in length, *plus* the 9-octet frame header”

so the removal of the subtraction of 9 from the payload length looks correct.

Thanks,

Brian

[1] http://httpwg.org/specs/rfc7540.html#FrameSize

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/net-dev/attachments/20160708/f56c4724/attachment.html>