RFR 8144692: HttpServer API: use of non-existant method in example in package Javadoc

Chris Hegarty chris.hegarty at oracle.com
Wed Jul 13 11:06:23 UTC 2016


On 12/07/16 13:53, Vyom Tewari wrote:
> Hi Pavel,
>
> Thanks for  review, i updated the
> webrev(http://cr.openjdk.java.net/~vtewari/8144692/webrev0.0/index.html
> <http://cr.openjdk.java.net/%7Evtewari/8144692/webrev0.0/index.html>) in
> place.

Looks fine.

-Chris.

> Thanks,
> Vyom
>
>
> On Tuesday 12 July 2016 06:10 PM, Pavel Rappo wrote:
>> Hi Vyom,
>>
>> A minor comment. Do you think it would make sense to use space after
>>
>>      new InetSocketAddress(8000),
>> as in every other line in this javadoc where multiple arguments
>> passed, the
>> space is used. Just to be consistent in formatting.
>>
>> Thanks.
>>
>>> On 12 Jul 2016, at 12:36, Vyom Tewari <vyom.tewari at oracle.com> wrote:
>>>
>>> Hi All,
>>>
>>> Please review below small doc fix.
>>>
>>> Bug            : JDK-8144692 HttpServer API: use of non-existant
>>> method in example in package Javadoc
>>> Webrev      :
>>> http://cr.openjdk.java.net/~vtewari/8144692/webrev0.0/index.html
>>> <http://cr.openjdk.java.net/%7Evtewari/8144692/webrev0.0/index.html>
>>>
>>> Thanks,
>>> Vyom
>


More information about the net-dev mailing list