8158519: Incorrect network mask and broadcast address on Linux when there are multiple IPv4 addresses on an interface

[Dmitry Samersoff]

Chris,

Looks good for me. Only minor nits (no need to re-review).

1040 missed space before {

1158 please, add comment and {} around continue.

1938  I'm not sure that check for IFF_POINTOPOINT is necessary (but
don't mid to leave it). Do you know the case when both flags are set?

-Dmitry

On 2016-06-02 15:06, Chris Hegarty wrote:
> Doychin, et al,
> 
> I finally got time to look at the issue you reported and your suggested patch. I filed
> 8158519 [1] to track the issue. I think your suggested patch may be ok, but I just 
> wanted to push on the ioctl approach. I found an alternative, and verified that it 
> works as expected. Please take a look, and verify in your environment.  Then we 
> need to weigh up the two separate approaches.
> 
> http://cr.openjdk.java.net/~chegar/8158519.00/
> 
> For the record, I don’t have any specific issue with using getifaddrs, I just wanted to
> see if there was a less invasive change. That said, using getifaddrs could lead to
> cleaner code, but we would need to check the situation on AIX ( which I don’t have 
> access to ).
> 
> -Chris.
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8158519
>