RFR 8071660 :URLPermission not handling empty method lists correctly

Daniel Fuchs daniel.fuchs at oracle.com
Sun Jun 12 08:34:56 UTC 2016


Hi Vyom,

This looks strange to me:

  268         if(!this.methods.isEmpty() && that.methods.isEmpty())
  269             return true;
  270         if(this.methods.isEmpty() && !that.methods.isEmpty())
  271             return false;
  272         if(this.methods.isEmpty() && that.methods.isEmpty())
  273             return true;

Namely, lines 269 & 273 will return true before the URL part
of the permission has been checked.
Is that really the expected behavior?

best regards,

-- daniel

On 11/06/16 05:50, vyom wrote:
> Hi All,
>
> Please review the below fix.
>
> Bug       :         JDK-8071660 URLPermission not handling empty method
> lists correctly
> Webrev :
> http://cr.openjdk.java.net/~vtewari/8071660/webrev0.0/index.html
> <http://cr.openjdk.java.net/%7Evtewari/8071660/webrev0.0/index.html>
>
> Thanks,
> Vyom



More information about the net-dev mailing list