RFR JDK-8151913: Fix module dependencies in java/net tests

Alan Bateman Alan.Bateman at oracle.com
Sun Jun 12 18:34:34 UTC 2016



On 11/06/2016 08:59, John Jiang wrote:
> Hi,
> Just restarted this job.
>
> On 2016/4/29 15:34, Alan Bateman wrote:
>
>> On 28/04/2016 05:50, John Jiang wrote:
>>> Hi,
>>> Please review another webrev: 
>>> http://cr.openjdk.java.net/~jjiang/8151913/webrev.02
>>> The java.httpclient module declaration is removed from all of 
>>> java/net/httpclient tests, even though some ones have to declare 
>>> other modules.
>> If a test has the @modules tag then then the "modules" key in the 
>> test suite configuration (TEST.properties) won't be used. That is, 
>> @modules overrides rather than augments. I just re-read the tag spec 
>> [1] and I think have this right. In that case, the java.httpclient 
>> tests that have @modules jdk.httpserver will need to list 
>> java.httpclient too.
> Please review the updated webrev: 
> http://cr.openjdk.java.net/~jjiang/8151913/webrev.03
> Additionally, test/java/net/CookieHandler/CookieManagerTest.java and 
> test/java/net/HttpURLConnection/UnmodifiableMaps.java have defined 
> @modules, so this new patch excludes them.
The updated patch looks okay to me.

-Alan


More information about the net-dev mailing list