RFR 8148609: supportedOptions() methods return a mutable set

[Chris Hegarty]

On 3 Mar 2016, at 05:36, Vyom Tewari <vyom.tewari at oracle.com> wrote:

> please find the updated webrev
> 
> http://cr.openjdk.java.net/~nkumar/vyom/8148609/webrev0.2/ <http://cr.openjdk.java.net/%7Enkumar/vyom/8148609/webrev0.2/>

Looks fine.

-Chris.

> Thanks,
> Vyom
> 
> 
> On 3/2/2016 2:36 PM, Chris Hegarty wrote:
>>> On 2 Mar 2016, at 08:19, Alan Bateman <Alan.Bateman at oracle.com> wrote:
>>> 
>>> 
>>> 
>>> On 02/03/2016 06:47, vyom wrote:
>>>> Hi Chris/Alan,
>>>> 
>>>> Thanks for review, please find the updated webrev(http://cr.openjdk.java.net/~nkumar/vyom/8148609/webrev0.1/index.html <http://cr.openjdk.java.net/%7Enkumar/vyom/8148609/webrev0.1/index.html>).
>>> This looks much better.
>> +1
>> 
>>> I see the test is named SupportedOptionTest and so hints that it tests more than it does. I wonder if we could find a better name for it, maybe ImmutableOptions or something along those lines.
>> ImmutableOptions is better.
>> 
>> -Chris.
>