RFR 8150521: Test test/java/net/InetAddress/getOriginalHostName.java fails to load JavaNetInetAddressAccess from SharedSecrets
Chris Hegarty
chris.hegarty at oracle.com
Thu Mar 3 09:04:04 UTC 2016
On 3 Mar 2016, at 05:33, Vyom Tewari <vyom.tewari at oracle.com> wrote:
> incorporated the review comment, updated webrev in place.
>
> http://cr.openjdk.java.net/~nkumar/vyom/8150521/webrev0.1/index.html <http://cr.openjdk.java.net/%7Enkumar/vyom/8150521/webrev0.1/index.html>
Looks fine.
-Chris.
> Vyom
>
> On 3/2/2016 1:45 PM, Alan Bateman wrote:
>> On 02/03/2016 07:44, vyom wrote:
>>> Hi Chris,
>>>
>>> Thanks for review please find the updated webrev(http://cr.openjdk.java.net/~nkumar/vyom/8150521/webrev0.1/index.html <http://cr.openjdk.java.net/%7Enkumar/vyom/8150521/webrev0.1/index.html>).
>> This looks okay to me. Style wide, can you put a space in "if(" to keep it consistent.
>>
>> -Alan.
>
More information about the net-dev
mailing list