RFR 8148609: supportedOptions() methods return a mutable set
Chris Hegarty
chris.hegarty at oracle.com
Thu Mar 3 17:25:46 UTC 2016
On 3 Mar 2016, at 09:39, Vyom Tewari <vyom.tewari at oracle.com> wrote:
> i need sponsor for this fix.
I pushed this:
http://hg.openjdk.java.net/jdk9/dev/jdk/rev/49781476b709
, with a few additional modifications:
1) Unrelated; added missing @since tags to impl supportedOptions
( these were missing when the methods were original added, but
worth adding while here )
2) I made some modifications to the test, since it did not reproduce
the issue. It tested only the socket types, not the socket impl’s.
-Chris.
> Vyom
>
> On 3/3/2016 2:37 PM, Alan Bateman wrote:
>>
>>
>> On 03/03/2016 09:03, Chris Hegarty wrote:
>>> On 3 Mar 2016, at 05:36, Vyom Tewari <vyom.tewari at oracle.com> wrote:
>>>
>>>> please find the updated webrev
>>>>
>>>> http://cr.openjdk.java.net/~nkumar/vyom/8148609/webrev0.2/ <http://cr.openjdk.java.net/%7Enkumar/vyom/8148609/webrev0.2/>
>>> Looks fine.
>>>
>> Looks okay to me too.
>>
>> -Alan
>
More information about the net-dev
mailing list