RFR 8151281: Module java.httpclient could use System.Logger instead of PlatformLogger

Mandy Chung mandy.chung at oracle.com
Tue Mar 15 05:35:07 UTC 2016


> On Mar 14, 2016, at 6:41 AM, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
> 
> Hi Mandy,
> 
> On 06/03/16 00:01, Mandy Chung wrote:
>> Hi Daniel,
>> 
>>> On Mar 4, 2016, at 8:05 AM, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
>>> 
>>> Please find below a patch for:
>>> 
>>> https://bugs.openjdk.java.net/browse/JDK-8151281
>>> 8151281: Module java.httpclient could use System.Logger
>>>         instead of PlatformLogger
>>> 
>>> http://cr.openjdk.java.net/~dfuchs/webrev_8151281/webrev.00/
>> 
>> 
>> I’m happy to see usage of PlatformLogger being converted to System.Logger.
>> 
>> Is there any reason why Log can’t be a concrete implementation class?
> 
> It could but it would still be a bit artificial and would add an
> extra call layer in the call stack. I considered it but opted for
> the simpler solution.
> 

It’s a nice trick.  Perhaps define a new internal class that implements System.Logger with default methods.  Any platform classes want itself to be skipped will extend that new internal class?

Mandy


More information about the net-dev mailing list