RFR 7167293:FtpURLConnection connection leak on FileNotFoundException
Chris Hegarty
chris.hegarty at oracle.com
Tue Mar 15 11:41:08 UTC 2016
Vyom,
On 15/03/16 10:00, vyom wrote:
> Hi,
>
> Please review the below fix.
>
> Bug: JDK-7167293 : FtpURLConnection connection leak on
> FileNotFoundException
> Webrev: http://cr.openjdk.java.net/~rgoel/~vyom/7167293/webrev0.0/
> <http://cr.openjdk.java.net/%7Ergoel/%7Evyom/7167293/webrev0.0/>
You have the same lines of code in a number of places. Does
a private static helper method make sense for this?
Test tries to connect to an external resource, which is not
reachable on my, and many, systems. Can the test setup a simple
ServerSocket to do something minimal?
-Chris.
More information about the net-dev
mailing list