RFR 7167293:FtpURLConnection connection leak on FileNotFoundException

vyom vyom.tewari at oracle.com
Mon Mar 21 09:19:14 UTC 2016


Hi,

Please find the updated webrev, got some off line comment from Chris.

http://cr.openjdk.java.net/~vtewari/7167293/webrev0.2/index.html 
<http://cr.openjdk.java.net/%7Evtewari/7167293/webrev0.2/index.html>

Thanks,
Vyom

On Thursday 17 March 2016 12:30 PM, vyom wrote:
> please find the updated 
> webrev(http://cr.openjdk.java.net/~vtewari/7167293/webrev0.1/index.html <http://cr.openjdk.java.net/%7Evtewari/7167293/webrev0.1/index.html>). 
>
> Thanks,
> Vyom
>
> On Tuesday 15 March 2016 05:11 PM, Chris Hegarty wrote:
>> Vyom,
>>
>> On 15/03/16 10:00, vyom wrote:
>>> Hi,
>>>
>>> Please review the below fix.
>>>
>>> Bug: JDK-7167293 : FtpURLConnection connection leak on
>>> FileNotFoundException
>>> Webrev: http://cr.openjdk.java.net/~rgoel/~vyom/7167293/webrev0.0/
>>> <http://cr.openjdk.java.net/%7Ergoel/%7Evyom/7167293/webrev0.0/>
>>
>> You have the same lines of code in a number of places. Does
>> a private static helper method make sense for this?
>>
>> Test tries to connect to an external resource, which is not
>> reachable on my, and many, systems.  Can the test setup a simple
>> ServerSocket to do something minimal?
>>
>> -Chris.
>



More information about the net-dev mailing list