RFR(S): 8156521: Minor Fixes and cleanups in NetworkInterface.c
Dmitry Samersoff
dmitry.samersoff at oracle.com
Wed May 11 07:43:51 UTC 2016
Christoph,
Looks good for me (Reviewed).
Few more space nits (no need to re-review)
1141 Missed space around = in i=0
1890 extra space after (
2068 wrong indent
-Dmitry
On 2016-05-10 12:54, Langer, Christoph wrote:
> Hi all,
>
>
>
> can I please get a review for a change to NetworkInterface.c
>
>
>
> bugreport: https://bugs.openjdk.java.net/browse/JDK-8156521
>
> webrev: http://cr.openjdk.java.net/~clanger/webrevs/8156521.0/
>
>
>
> Apart from quite a few whitespace changes to clean up the coding, I went
> through and replaced all occurences of strcpy with strncpy as this was a
> finding of a code scanner that we used. Also in function
> “enumIPv6Interfaces” for Linux the local variable plen was changed from
> int to short.
>
>
>
> I ran builds on Linux, AIX, Solaris Sparc and Darwin to make sure
> nothing broke.
>
>
>
> Thanks in advance
>
> Christoph
>
>
>
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
More information about the net-dev
mailing list