RFR 8136933: Additional tests for Solaris SO_FLOW_SLA socket option in JDK 9

[Svetlana Nikandrova]

Alan,

another test related to this option is on the same level 
(test/jdk/net/SocketFlow) so I thought it's ok to maintain the same 
hierarchy. I can move test to 
test/jdk/net/Sockets/ExtendedSocketOptions/SO_FLOW_SLA or to 
test/jdk/net/Sockets, but in that case won't it be a little bit confusing?

As for overlapping coverage: existing test silently exits if option is 
not in supported list while this one is focused on platform support check.

Thank you,
Svetlana

On 20.05.2016 15:07, Alan Bateman wrote:
> On 20/05/2016 11:16, Svetlana Nikandrova wrote:
>> Hi Artem,
>>
>> thank you for your comments. Please see updated review:
>> http://cr.openjdk.java.net/~snikandrova/8136933/webrev.01/ 
>> <http://cr.openjdk.java.net/%7Esnikandrova/8136933/webrev.01/>
>>
>>  I've moved version check to OSInfo.java and used ProcessTools. Also 
>> made a little change in ProcessTools (Throwable didn't make sense 
>> there). I also updated comment for checkSocketOption() method to 
>> indicate that it is fine to not get any exception. Actually as this 
>> test is meant to check platform support we are only interested in 
>> UnssuportedOperationException. More usage scenarios with SO_FLOW_SLA 
>> option are covered by 
>> http://hg.openjdk.java.net/jdk9/jdk9/jdk/file/tip/test/jdk/net/Sockets/Test.java
> Yes, there is an existing test in test/jdk/net/Sockets/Test.java and 
> seems strange to have the tests in different locations (maybe some 
> overlapping coverage too).
>
> -Alan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/net-dev/attachments/20160520/ba4b9097/attachment.html>