RFR 8136933: Additional tests for Solaris SO_FLOW_SLA socket option in JDK 9
Svetlana Nikandrova
svetlana.nikandrova at oracle.com
Wed May 25 13:18:45 UTC 2016
Thank you, Chris!
On 25.05.2016 16:08, Chris Hegarty wrote:
> On 25 May 2016, at 14:04, Svetlana Nikandrova <svetlana.nikandrova at oracle.com> wrote:
>> Hi Chris,
>>
>> thank you for your comments. Please see updated review. (I left braces in one line "if" blocks, hope it wasn't strong objection)
>>
>> http://cr.openjdk.java.net/~snikandrova/8136933/webrev.04/ <http://cr.openjdk.java.net/%7Esnikandrova/8136933/webrev.04/>
> I think this is fine.
>
>
>>> - Can you please revert the indentation on SocketFlow.create(),
>>> i.e. line up the dots
> Trivially, before you push, just revert this to the way it was, dots
> lined up vertically. no need to regenerate the webrev.
>
> -Chris.
>
More information about the net-dev
mailing list