RFR: 8170544: Fix code scan findings in libnet

Michael McMahon michael.x.mcmahon at oracle.com
Wed Nov 30 16:57:02 UTC 2016


I will run the change through JPRT Christoph

Thanks
Michael

On 30/11/2016, 16:32, Langer, Christoph wrote:
>
> Hi,
>
> please review the following change:
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8170544
>
> Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8170544.0/ 
> <http://cr.openjdk.java.net/%7Eclanger/webrevs/8170544.0/>
>
> With this change I change some function signatures to use 
> SOCKETADDRESS * instead of struct sockaddr * where appropriate. This 
> fixes some code scan findings, which reported the fact that it's 
> dangerous to pass struct socaddr * pointers and then cast it to the 
> wider struct sockaddr_in6. I think this makes the code cleaner and 
> spares some casts at several places.
>
> Please review and run through JPRT testing.
>
> Thanks
>
> Christoph
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/net-dev/attachments/20161130/46d5e399/attachment.html>


More information about the net-dev mailing list