RFR(s): 8166791: Fix module dependencies for networking component tests

Chris Hegarty chris.hegarty at oracle.com
Mon Oct 3 13:05:03 UTC 2016


Sergei,

On 03/10/16 11:08, Sergei Kovalev wrote:
> Resending this for review
>
>
> 27.09.16 18:44, Sergei Kovalev wrote:
>> Hi team,
>>
>> Could you please review small fix for regression tests.
>>
>> BugID: https://bugs.openjdk.java.net/browse/JDK-8166791
>> WebRev: http://cr.openjdk.java.net/~skovalev/8166791/webrev.00/

>> Issue: Severl network related tests failed in case of using
>> "--limit-modules java.base" command line option.
>>
>> The test java/net/httpclient/http2/ErrorTest.java should declare
>> dependencies on 'jdk.security.auth' module.

I cannot find the reason why you think this module needs
jdk.security.auth, can you please explain.

>> java/net/httpclient/security/Driver.java should depend oh
>> 'java.httpclient' and 'jdk.httpserver'.
>>
>> java/net/spi/URLStreamHandlerProvider/Basic.java and
>> sun/net/www/protocol/jar/MultiReleaseJarURLConnection.java have
>> declaration of dependency on 'java.compiler' but should be
>> 'jdk.compiler'.

They should require both java.compiler and jdk.compiler, no?

>> From the test java/net/httpclient/http2/HpackDriver.java extracted one
>> part that depends on 'jdk.localedata':
>> java/net/httpclient/http2/HpackDriverHeaderTable.java because other
>> part don't have any extra dependencies and could be executed in
>> general case.

-Chris.



More information about the net-dev mailing list