RFR(s): 8166791: Fix module dependencies for networking component tests

Chris Hegarty chris.hegarty at oracle.com
Mon Oct 3 14:22:34 UTC 2016


On 03/10/16 15:19, Sergei Kovalev wrote:
> Changed
>
> http://cr.openjdk.java.net/~skovalev/8166791/webrev.03/

This looks fine. Reviewed.

No need to generate the webrev, but can you please check that you list
the java.* modules before the jdk.* ones.

Thanks,
-Chris.


> 03.10.16 17:07, Alan Bateman wrote:
>>
>>
>> On 03/10/2016 15:05, Sergei Kovalev wrote:
>>> Such notation (module/package) helps to jtreg to understand that the
>>> module required on compilation stage. Jtreg adding "--add-exports
>>> module/package=ALL-UNNAMED" for each record of this type. In our case
>>> id adds a string: --add-exports java.compiler/javax.tools=ALL-UNNAMED.
>>>
>> Chris is right, there is no need for "/javax.tools" here.
>>
>> -Alan
>>
>


More information about the net-dev mailing list