RFR(XXS): 8168471: Non ANSI C declaration of block local variable in NetworkInterface_winXP.c
Volker Simonis
volker.simonis at gmail.com
Fri Oct 21 12:49:14 UTC 2016
Hi,
can I please get a review for the following trivial fix:
http://cr.openjdk.java.net/~simonis/webrevs/2016/8168471/
https://bugs.openjdk.java.net/browse/JDK-8168471
Change "8168405: Pending exceptions in java.base/windows/native"
introduced the following non ANSI C compatible code for declaring a
block-level variable ("jboolean ret"):
} else /* AF_INET6 */ {
int scope;
iaObj = (*env)->NewObject(env, ia6_class, ia6_ctrID);
if (iaObj == NULL) {
return NULL;
}
jboolean ret = setInet6Address_ipaddress(env, iaObj, (jbyte
*)&(addrs->addr.sa6.sin6_addr.s6_addr));
But ANSI C only allows the declaration of block local variable at the
beginning of a block.Unfortunately some still very common compilers
like Microsoft VS2010 and VS2012 still don't support this C99 feature
:(
Thank you and best regards,
Volker
More information about the net-dev
mailing list