RFR - 8159410: InetAddress.isReachable returns true for non existing IP addresses

[Mark Sheppard]

the IcmpSendEcho series of calls come with some idiosyncrasies in that 
there is a minimum timeout that they can handle
think it is about 1000msecs. isReachable can specify a finer grained 
timeout hence the need for timeout check

regards
Mark

On 21/09/2016 17:18, Vyom Tewari wrote:
>
> Hi Rob,
>
> Do you really think this extra check is required ?
>
> if (pEchoReply->Status == IP_SUCCESS
> + && (int)pEchoReply->RoundTripTime <= timeout) I did not found any 
> doc(MSDN) which explains this. I think in case of IP_SUCCESS 
> "RoundTripTime" is always less than timeout. I think similar changes 
> is required in Inet6Address.c as well ? Thanks, Vyom
>
> On Wednesday 21 September 2016 08:46 PM, Rob McKenna wrote:
>> Hi folks,
>>
>> I'd like to fix a bug caused by an incorrect assumption. The IcmpSendEcho* calls can actually return a similar set of errors regardless of whether the call itself failed or succeeded. This change checks that both the call and the ping were successful. In addition to that it takes a number of common failure causes into account before deciding to throw an exception.
>>
>> http://cr.openjdk.java.net/~robm/8159410/webrev.01/
>>
>> 	-Rob
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/net-dev/attachments/20160921/4d129e2b/attachment.html>