[PATCH] 8035653: jdk8u152-b01 windows crash on DatagramSocket.getLocalAddress

[Langer, Christoph]

Hi Alex,

to me your patch looks good.

But since I'm not a JDK8 Reviewer, someone with this merits has to review it. @Chris: May I ask you to have a look?

Thanks
Christoph

> -----Original Message-----
> From: Alex Kashchenko [mailto:akashche at redhat.com]
> Sent: Montag, 24. April 2017 15:22
> To: Langer, Christoph <christoph.langer at sap.com>
> Cc: net-dev at openjdk.java.net
> Subject: Re: [PATCH] 8035653: jdk8u152-b01 windows crash on
> DatagramSocket.getLocalAddress
> 
> Hi Christoph,
> 
> On 04/19/2017 10:53 AM, Langer, Christoph wrote:
> > Hi Alex,
> >
> > I've just quickly checked this and it seems worthwile to me to downport
> 8035653 to JDK8.
> >
> > As the patch will probably not apply cleanly to JDK8 after unshuffling [1] ,
> you will need to create a new public review and post it on this mailing list.
> Some JDK8 reviewer needs to review it and then you need to request
> approval for push into jdk8u-dev using this mail template [2]. After you've
> posted the webrev I can help you with the process.
> >
> > Generally, information about Java 8 backports can be found here: [3].
> 
> Thanks for your comments! I uploaded review [1] to downport 8035653 [2]
> to jdk8u/jdk8u-dev.
> 
> Patch from jdk9/dev [3] does not apply cleanly, change to
> DualStackPlainDatagramSocketImpl.java was already added to jdk8 as part
> of 8072466 [4][5].
> 
> This patch brings changes to DualStackPlainDatagramSocketImpl.c and also
> includes B8035653.java test.
> 
> 
> [1] http://cr.openjdk.java.net/~akasko/jdk8u/8035653/webrev.00/
> [2] https://bugs.openjdk.java.net/browse/JDK-8035653
> [3] http://hg.openjdk.java.net/jdk9/dev/jdk/rev/8e5e92e0530e
> [4] https://bugs.openjdk.java.net/browse/JDK-8072466
> [5] http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/3623f1b29b58#l7.1
> 
> >
> > Best regards
> > Christoph
> >
> > [1] http://cr.openjdk.java.net/~chegar/docs/portingScript.html
> > [2] http://openjdk.java.net/projects/jdk8u/approval-template.html
> > [3] http://openjdk.java.net/projects/jdk8u/
> >
> >
> >
> >
> >> -----Original Message-----
> >> From: net-dev [mailto:net-dev-bounces at openjdk.java.net] On Behalf Of
> >> Alex Kashchenko
> >> Sent: Donnerstag, 23. März 2017 00:51
> >> To: net-dev at openjdk.java.net
> >> Subject: [PATCH] 8035653: jdk8u152-b01 windows crash on
> >> DatagramSocket.getLocalAddress
> >>
> >> Hi,
> >>
> >> We found that 8035653 test from jdk9 [1] crashes jdk8u152-b01 on
> windows
> >> at this point [2] because "ia6_class" is not initialized.
> >>
> >> It looks like the following bit of 8035653 is missed in jdk8u152-b01:
> >>
> >> diff -r 83726fe0f756
> >> src/windows/native/java/net/DualStackPlainDatagramSocketImpl.c
> >> --- a/src/windows/native/java/net/DualStackPlainDatagramSocketImpl.c
> >> Tue Mar 21 17:08:03 2017 -0700
> >> +++
> b/src/windows/native/java/net/DualStackPlainDatagramSocketImpl.c
> >> Wed Mar 22 23:18:30 2017 +0000
> >> @@ -87,6 +87,8 @@
> >>       IO_fd_fdID = NET_GetFileDescriptorID(env);
> >>       CHECK_NULL(IO_fd_fdID);
> >>       JNU_CHECK_EXCEPTION(env);
> >> +
> >> +    initInetAddressIDs(env);
> >>   }
> >>
> >> If it will be convenient, I can submit an issue+webrev and re-send this
> >> to jdk8u-dev list. But as 8u152 is not yet released and the fix is
> >> already in jdk9, I will appreciate some guidance on this problem.
> >>
> >>
> >> [1]
> >>
> http://hg.openjdk.java.net/jdk9/jdk9/jdk/file/f6bf027e88e9/test/java/net/
> >> DatagramSocket/B8035653.java
> >> [2]
> >>
> http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/file/83726fe0f756/src/share/na
> >> tive/java/net/net_util.c#l222
> >>
> >> --
> >> -Alex
> 
> 
> --
> -Alex