[10] RFR: 8186930: Constant fold URI constants
Alan Bateman
Alan.Bateman at oracle.com
Wed Aug 30 14:10:18 UTC 2017
On 29/08/2017 21:26, Claes Redestad wrote:
> Hi,
>
> please review this patch to pre-calculate constants in java.net.URI and
> sun.net.www.ParseUtil, removing work from runtime (reduces bytecodes
> executed in the interpreter on bootstrap by ~15K).
>
> This also removes use of BitSet from ParseUtil, which apart from being a
> startup improvement also yields a small throughput improvement (~5%).
>
> Webrev: http://cr.openjdk.java.net/~redestad/8186930/jdk.00/
This looks good to me. I just wonder if ParseUtil should keep the
lowMask/highMask methods in comments so that further maintainers can
satisfy themselves that the values are correct.
-Alan
More information about the net-dev
mailing list