[10] RFR: 8186930: Constant fold URI constants

Claes Redestad claes.redestad at oracle.com
Thu Aug 31 16:41:47 UTC 2017


Hi Daniel,

I'm not sure: I have no love for whitebox tests in general, and 
especially not for code where doing exhaustive black box tests against a 
public API is possible and perhaps even straightforward (the test 
coverage seems adequate currently, but can of course always be improved).

/Claes

On 2017-08-30 18:16, Daniel Fuchs wrote:
> Hi Claes,
>
> Maybe it could be interesting to leave the
> methods in a static inner class which is
> not referenced (except by whitebox tests) and
> have this inner class expose a static test()
> method that would test that the static fields
> in URI have the expected value?
>
> This is just a suggestion,  and it
> could be done in a followup RFE...
>
> best regards,
>
> -- daniel
>
> On 31/08/2017 16:26, Claes Redestad wrote:
>>
>> On 2017-08-30 17:17, Alan Bateman wrote:
>>> I think it could be useful as someone reading the code isn't going 
>>> to immediately know to jump to URI.
>>
>> Done: http://cr.openjdk.java.net/~redestad/8186930/jdk.01/
>>
>> /Claes
>>
>



More information about the net-dev mailing list