RFR 8193365: Improve interoperability between HTTP Client's BodyPublisher/BodySubscriber and Flow.Subscriber/Publisher

Daniel Fuchs daniel.fuchs at oracle.com
Wed Dec 20 09:29:32 UTC 2017


Hi Chris,

This looks good to me. I wonder if the implementations of Susbscriber
in the tests should be strengthened.

I see that onError or onNext could throw exception - and
though SubscriberAdapter seems to (partly) cater for it in
onError, it doesn't do anything for onNext.

I also wonder if the wrapper (SubscriberAdapter) should forcefully
cancel the subscribtion if its wrappee (the test Subscriber) throws
unexpected errors or unchecked exception in onError/onNext/onComplete

best regards,

-- daniel

For instance I see that

On 15/12/2017 15:37, Chris Hegarty wrote:
> This review is for 8193365 [1], to improve interoperability
> between HTTP Client's BodyPublisher/BodySubscriber and
> Flow.Subscriber/Publisher, that was raised as part of
> feedback on JEP 321 [2].
> 
> http://cr.openjdk.java.net/~chegar/8193365/webrev.01/
> 
> -Chris.
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8193365
> [2] 
> http://mail.openjdk.java.net/pipermail/net-dev/2017-December/thread.html#11063 
> 



More information about the net-dev mailing list