Ping~ Re: RFR 8181080/10, Refactor several sun/net shell tests to plain java tests

[Amy Lu]

sun/net/www/protocol/file/DirPermissionDenied.java

+
+ @BeforeTest
+ public void setup() throws Throwable {
+ // mkdir and chmod "333"
+ Files.createDirectories(TEST_DIR);
+ ProcessTools.executeCommand("chmod", "333", TEST_DIR.toString()) Maybe just do this with java api instead run chmod command?

+
+ @AfterTest
+ public void tearDown() throws IOException {
+ if (Files.exists(TEST_DIR)) {
+ Files.delete(TEST_DIR);
+ }
+ }

Missed "Add back read access" before trying to delete it?

Thanks,
Amy

On 6/6/17 9:33 AM, Felix Yang wrote:
> Thanks:-)
> -Felix
> On 2017/6/1 16:32, Felix Yang wrote:
>> Hi there,
>>
>>     please review the patch convert several sun/net shell tests to 
>> plain java tests.
>>
>> Bug:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8181080
>>
>> Webrev:
>>
>> http://cr.openjdk.java.net/~xiaofeya/8181080/webrev.00/
>>
>> Thanks,
>>
>> Felix
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/net-dev/attachments/20170606/7ab570f0/attachment-0001.html>