RFR 8179602: Fix for JDK-8165437 is broken on 32-bit Linux

Langer, Christoph christoph.langer at sap.com
Thu May 4 08:57:15 UTC 2017


Hi Vyom,

the fix looks good and seems straightforward to resolve the reported issue.

Small item: I spotted an extra space in net_util_md.h, line 75, between "jlong" and "nanoTimeStamp" which could be removed.

Reviewed.

Best regards
Christoph

> -----Original Message-----
> From: net-dev [mailto:net-dev-bounces at openjdk.java.net] On Behalf Of
> Vyom Tewari
> Sent: Donnerstag, 4. Mai 2017 10:50
> To: net-dev <net-dev at openjdk.java.net>
> Subject: RFR 8179602: Fix for JDK-8165437 is broken on 32-bit Linux
> 
> Hi All,
> 
> Please  review the below change.
> 
> Webrev:
> http://cr.openjdk.java.net/~vtewari/8179602/webrev0.0/index.html
> 
> Bugid: https://bugs.openjdk.java.net/browse/JDK-8179602
> 
> This issue is because of side effect of "JDK-8165437" where we are using
> "JVM_NanoTime" which returns a 64 bit jlong and return value was getting
> assigned to long type. On 32 bit OS long is 4 byte, which leads to
> integer overflow.
> 
> Our internal test JPRT is  still running.
> 
> Thanks,
> 
> Vyom



More information about the net-dev mailing list