RFR 8179905: Remove the use of gettimeofday in Networking code

Claes Redestad claes.redestad at oracle.com
Tue May 9 17:50:21 UTC 2017


Hi,

doesn't this need to consider numerical overflows, e.g., what happens if 
someone sets a timeout value near 0x7fffffffffffffffL before and after 
this change?

/Claes

On 2017-05-09 11:55, Vyom Tewari wrote:
> Hi ,
>
> Please review the code change for below issue.
>
> Webrev  : 
> http://cr.openjdk.java.net/~vtewari/8179905/webrev0.0/index.html
>
> BugId     : https://bugs.openjdk.java.net/browse/JDK-8179905
>
> This issue is duplicate of "JDK-8165437", where pushed code change 
> failed on 32 bit platforms so we revert back code changes as part of 
> "JDK-8179602".
>
> Please find below is the webrev that was pushed as part of "JDK-8165437".
>
> Webrev  : 
> http://cr.openjdk.java.net/~vtewari/8165437/webrev0.7/index.html
>
> Thanks,
>
> Vyom
>



More information about the net-dev mailing list