RFR (9): 8180498 Remove httpclient internal APIs which supply ByteBuffers to read calls

Daniel Fuchs daniel.fuchs at oracle.com
Fri May 19 16:42:45 UTC 2017


Hi Michael,

Looks good - but what purpose does the rxBuffer now
serves in Exchange.java?

If I'm not mistaken it's an empty 0 sized buffer that
is never replaced... At the very least it should be
final (and not volatile), but maybe getBuffer() could
simply be removed here?

best regards,

-- daniel

On 19/05/2017 15:29, Michael McMahon wrote:
> Could I get the following change reviewed please?
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8180498
>
> Webrev: http://cr.openjdk.java.net/~michaelm/8180498/webrev.1/
>
> Thanks,
> Michael.



More information about the net-dev mailing list