RFR(S): 8155590: Dubious collection management in sun.net.www.http.KeepAliveCache

[vyom tewari]

Hi Christoph,

Thanks for doing this, i think you don't need to synchronize the 
"remove(HttpClient h)".  This remove is get called from synchronize 
"remove (HttpClient h, Object obj)" and the underline data structure is 
which is java.util.Vector(ClientVector extends java.util.Stack) is also 
thread safe.

What do you think ?

Thanks,

Vyom


On Monday 16 October 2017 12:52 PM, Langer, Christoph wrote:
>
> Hi,
>
> Here is a proposal for a fix for bug 8155590. I already made this fix 
> a while ago in our JDK clone and I’d like to contribute this.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8155590 
> <https://bugs.openjdk.java.net/browse/JDK-8155590>
>
> Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8155590.0/ 
> <http://cr.openjdk.java.net/%7Eclanger/webrevs/8155590.0/>
>
> Please review.
>
> Thanks
>
> Christoph
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/net-dev/attachments/20171016/693974ee/attachment.html>