RFR 8134989/10, java/net/MulticastSocket/TestInterfaces.java failed due to unexpected IP address

Roger Riggs Roger.Riggs at Oracle.com
Fri Sep 1 13:41:36 UTC 2017


Hi Felix,

Looks ok; though could be simpler to just print all the addresses of all 
NIs.

findIntefacesWithDupAddress could use streams more effectively (if its 
worth the time to rewrite).

The inetAddresses() method on NetworkInterface produces a stream of 
InetAddress which could
be filtered by "ia" and use anyMatch:.

Maybe something like:

List<NetworkInterface> nis = NetworkInterface.networkInterfaces()
                     .filter(i -> !i.equals(ni))
                     .filter(i -> i.inetAddresses().anyMatch(n -> 
n.equals(ia)))
                     .collect(Collectors.toList());

$.02, Roger

On 9/1/2017 3:47 AM, Felix Yang wrote:
> Hi there,
>
>     please review a test patch for isolating a network configuration 
> issue, which led to TestInterfaces failing from time to time.
>
> Bug:
>
>     https://bugs.openjdk.java.net/browse/JDK-8134989
>
> Webrev:
>
>     http://cr.openjdk.java.net/~xiaofeya/8134989/webrev.00/
>
> Thanks,
>
> Felix
>



More information about the net-dev mailing list