RFR:8194298 Add support for per Socket configuration of TCP keepalive
Alan Bateman
Alan.Bateman at oracle.com
Sun Apr 15 08:03:58 UTC 2018
On 14/04/2018 08:09, Alan Bateman wrote:
> :
>
> Can you update SocketChannel/SocketOptionTests.java to ensure that
> SocketChannel is test? We also need to ensure that the new options
> don't show up in the supportedOptions returned by the channels that
> don't support these new options.
Just on this point, I think this needs work in ExtendedSocketOptions so
that the extended options are organized by socket type (STREAM or
DGRAM). This will become a lot more obvious once you add tests for
SocketChannel as its implementation will need a change to pick up the
extended options for STREAM sockets. It will also avoid the filtering in
PlainDatagramSocketImpl that you've added to work around the issue there.
-Alan
More information about the net-dev
mailing list