RFR 8201510 : Merge TwoStacksPlainSocketImpl into DualStackPlainSocketImpl [win]

[Chris Hegarty]

Ivan,

On 16/04/18 17:29, Ivan Gerasimov wrote:
> ...
> WEBREV: http://cr.openjdk.java.net/~igerasim/8201510/00/webrev/

I think this is mostly good. Just one comment.


I'm not sure that this is correct.

--- OLD ---

   60         String exclBindProp = AccessController.doPrivileged(
   61                 new GetPropertyAction("sun.net.useExclusiveBind", 
""));
   62         exclusiveBind = (exclBindProp.isEmpty())
   63                 ? true
   64                 : Boolean.parseBoolean(exclBindProp);

--- NEW ---
  private static final boolean useExclusiveBind =
   55             Boolean.parseBoolean(AccessController.doPrivileged(
   56                 new GetPropertyAction("sun.net.useExclusiveBind", 
"true")));

Exclusive bind should be true iif:
   1) it is defined and has no value, or
   2) if is defined and has a value of `true`.

I thought we had tests for this, but maybe not if you are not
seeing test failures.

-Chris.