RFR 8202091 : Rename DualStackPlainSocketImpl to PlainSocketImpl [win]

Langer, Christoph christoph.langer at sap.com
Mon Apr 23 06:38:13 UTC 2018


Hi Ivan,

this looks good to me. Next nice step in cleaning up the socket implementation.

Best regards
Christoph

> -----Original Message-----
> From: net-dev [mailto:net-dev-bounces at openjdk.java.net] On Behalf Of
> Ivan Gerasimov
> Sent: Freitag, 20. April 2018 22:40
> To: net-dev at openjdk.java.net
> Subject: Re: RFR 8202091 : Rename DualStackPlainSocketImpl to
> PlainSocketImpl [win]
> 
> The correct links to the Bug and webrev are:
> 
> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8202091
> WEBREV: http://cr.openjdk.java.net/~igerasim/8202091/00/webrev/
> 
> Sorry for confusion!
> 
> With kind regards,
> Ivan
> 
> On 4/20/18 1:32 PM, Ivan Gerasimov wrote:
> > Hello!
> >
> > After integrating the fix for JDK-8201510, there is only one
> > implementation of PlainSocketImpl left on Windows.
> >
> > It is proposed to just rename DualStackPlainSocketImpl to
> > PlainSocketImpl and avoid the indirection.
> >
> > Some minor cleanup was done with this change:
> > - dropping static PlainSocketImpl.isReusePortAvailable() -- it wasn't
> > called anyway and just hid the same named function in the super class,
> > - minor re-formatting.
> >
> > Would you please help review the fix?
> >
> > Thanks in advance!
> >
> 
> --
> With kind regards,
> Ivan Gerasimov



More information about the net-dev mailing list