RFR 8202154 : Remove unused code in java.base/windows/native/libnet

Ivan Gerasimov ivan.gerasimov at oracle.com
Tue Apr 24 04:17:32 UTC 2018


Hello again!

A few other files contain obsolete code, so they can be combined 
together in one fix.

The webrev was updated in place:
http://cr.openjdk.java.net/~igerasim/8202154/00/webrev/

Here's the summary of additional changes:
- sun.net.PortConfig.getLower()/getUpper() always return the same range, 
so it can be defined with constants,
- NET_GetDefaultTOS() always returns zero, so it can be removed.

Would you please help review this?

With kind regards,
Ivan

On 4/23/18 2:29 PM, Ivan Gerasimov wrote:
> Hello!
>
> Some code in TwoStacksPlainDatagramSocketImpl.c is only relevant for 
> earlier versions of Windows, which are no longer supported as of JDK 11.
> This code can be safely removed.
>
> Also removing an unused argument at 
> DualStackPlainDatagramSocketImpl.socketCreate().
>
> Would you please help review this cleanup?
>
> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8202154
> WEBREV: http://cr.openjdk.java.net/~igerasim/8202154/00/webrev/
>
> Thanks in advance!
>

-- 
With kind regards,
Ivan Gerasimov



More information about the net-dev mailing list