RFR 8202154 : Remove unused code in java.base/windows/native/libnet

[Langer, Christoph]

Hi Ivan,

looks good. I agree that the fields that Vyom mentioned should be final.

Best regards
Christoph

From: net-dev [mailto:net-dev-bounces at openjdk.java.net] On Behalf Of vyom tewari
Sent: Dienstag, 24. April 2018 08:29
To: net-dev at openjdk.java.net
Subject: Re: RFR 8202154 : Remove unused code in java.base/windows/native/libnet


Hi Ivan,

code looks good to me, thanks for doing this cleanup. One minor comment, in PortConfig.java you can make defaultUpper& defaultLower as final.I see that Microsoft changed dynamic port range recently do we need to put some comment in PortConfig.java ?

Thanks,

Vyom



On Tuesday 24 April 2018 09:47 AM, Ivan Gerasimov wrote:
Hello again!

A few other files contain obsolete code, so they can be combined together in one fix.

The webrev was updated in place:
http://cr.openjdk.java.net/~igerasim/8202154/00/webrev/

Here's the summary of additional changes:
- sun.net.PortConfig.getLower()/getUpper() always return the same range, so it can be defined with constants,
- NET_GetDefaultTOS() always returns zero, so it can be removed.

Would you please help review this?

With kind regards,
Ivan

On 4/23/18 2:29 PM, Ivan Gerasimov wrote:

Hello!

Some code in TwoStacksPlainDatagramSocketImpl.c is only relevant for earlier versions of Windows, which are no longer supported as of JDK 11.
This code can be safely removed.

Also removing an unused argument at DualStackPlainDatagramSocketImpl.socketCreate().

Would you please help review this cleanup?

BUGURL: https://bugs.openjdk.java.net/browse/JDK-8202154
WEBREV: http://cr.openjdk.java.net/~igerasim/8202154/00/webrev/

Thanks in advance!


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/net-dev/attachments/20180424/b4452428/attachment.html>