RFR(XS): 8202181: Correctly specify size of hostname buffer in Unix Inet*AddressImpl_getLocalHostName implementations

Chris Hegarty chris.hegarty at oracle.com
Mon Apr 30 10:09:30 UTC 2018


On 30/04/18 11:07, Langer, Christoph wrote:
> Hi Chris,
> 
> thanks for looking at this. I just received positive confirmation from jdk-submit. Our internal tests did not show regressions as well. So I'll wait for word on your tests before submitting.

Do you have a link to the jdk-submit job, or anything
suitable for forwarding? I'm curious what test sets it ran.

-Chris.

> 
> Thanks
> Christoph
> 
>> -----Original Message-----
>> From: Chris Hegarty [mailto:chris.hegarty at oracle.com]
>> Sent: Montag, 30. April 2018 11:45
>> To: Langer, Christoph <christoph.langer at sap.com>; Thomas Stüfe
>> <thomas.stuefe at gmail.com>
>> Cc: net-dev at openjdk.java.net
>> Subject: Re: RFR(XS): 8202181: Correctly specify size of hostname buffer in
>> Unix Inet*AddressImpl_getLocalHostName implementations
>>
>>
>> On 30/04/18 09:00, Langer, Christoph wrote:
>>> ...
>>>>> Taking this input I have updated my webrev to round things up a little
>> bit:
>>>> http://cr.openjdk.java.net/~clanger/webrevs/8202181.1/
>> Thank you Christophe, this latest version looks good.
>> I'll run some tests on it and report the results by tomorrow.
>>
>> -Chris.
>>
>> P.S. I do remember adding the unconditional null termination
>> to this code years ago, but I suspect that it's been touched
>> a few times since.


More information about the net-dev mailing list