RFR [10] 8195823: Buffers given to response body subscribers should not contain unprocessed HTTP data

Michael McMahon michael.x.mcmahon at oracle.com
Mon Jan 22 19:25:54 UTC 2018


Looks fine to me Chris.

- Michael

On 22/01/2018, 16:56, Chris Hegarty wrote:
> It has been observed that byte buffers passed to the response
> subscriber may contain unprocessed data in the area between
> the buffer's limit and its capacity. This can happen when:
>   1) reading chunked HTTP/1.1 response data
>   2) receiving HTTP/2 data frames for several streams
>
> It is problematic for many reasons, least of all is that the
> asString and buffering subscribers accumulate bytes, below a
> certain threshold, into given buffers ( so as to not necessarily
> consumer memory ). There could also be other, more serious,
> issues.
>
> http://cr.openjdk.java.net/~chegar/8195823/webrev.01/index.html 
> <http://cr.openjdk.java.net/%7Echegar/8195823/webrev.01/index.html>
>
> -Chris.
>
> P.S. I will seek the required approval for 10 RDP 2 post code
> review.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/net-dev/attachments/20180122/1459525b/attachment.html>


More information about the net-dev mailing list