RFR: 8172346 sun.net.ftp.FtpDirEntry.setCreated(Date) may expose internal represent

[vyom tewari]

Hi Chris,

Thanks for review, please find my comment inline.

Thanks,

Vyom


On Tuesday 24 July 2018 06:54 PM, Chris Hegarty wrote:
> On 24 Jul 2018, at 10:55, vyom tewari <vyom.tewari at oracle.com> wrote:
>> Hi All,
>>
>> Please review below a trivial fix.
>>
>> Webrev : http://cr.openjdk.java.net/~vtewari/8172346/webrev0.0/index.html
>>
>> BugID: https://bugs.openjdk.java.net/browse/JDK-8172346
>>
>> The above code change will avoid storing the externally mutable object reference into FtpDirEntry.
> Is this defensive coding really needed here, given that the
> class is internal and only ever used by the FTP URL protocol
> handler?
It is good to have but i agree with you as class is internal and part of 
non-exported package so it is not really needed.
> If it is not really needed, then maybe we just close the bug as
> ‘not an issue’.
> -Chris.