[PATCH] SOCK_CLOEXEC for opening sockets

Chris Hegarty chris.hegarty at oracle.com
Tue Jul 24 20:34:20 UTC 2018


> On 19 Jul 2018, at 18:41, Andrew Luo <andrewluotechnologies at outlook.com> wrote:
> 
> Just checking - is there any other changes that I should make to the patch, or anything else you guys need me to do?

A webrev genderated from Andrew’s patch along with:

1) some additional includes of “net_util_md.h” in several missing places
    in the jdk.net module’s source, as well as the appropriate make change:
       EXTRA_HEADER_DIRS := \
          java.base:libnet, 

2) simplified the ifdef structure for NET_Socket and NET_SocketPair
    in net_util_md.c, and some comment updates, to make it more
    readable.

http://cr.openjdk.java.net/~chegar/8207335/webrev.00/

This successfully passes some preliminary testing, but I will need
someone to build / test on AIX.

-Chris.

P.S. The mailing list seems to have dropped the initial space on
the context lines of Andrew’s patch, which I had to restore before
it would apply cleanly.


More information about the net-dev mailing list