RFR of JDK-8199215: Re-examine getFreePort method in test infrastructure library

Hamlin Li huaming.li at oracle.com
Fri Mar 16 09:00:42 UTC 2018


On 16/03/2018 4:05 PM, Alan Bateman wrote:
> On 16/03/2018 01:54, Hamlin Li wrote:
>> :
>>
>> Hi Alan,
>> Thank you for detailed reviewing. I have updated the webrev in place. 
>> (http://cr.openjdk.java.net/~mli/8199215/webrev.00/)
> Looks good, just a minor typo "is better choice" -> "is a better choice".
Hi Alan,
Thank you, I will modify it when push.
>
> Just to confirm, have you run the serviceability and http client tests 
> to make sure that they compile with this change?
Yes, I ran tier1,tier2,tier3 tests(I think it includes httpclient 
tests), and also specific tests using Utils.getFreePort in svc area.
I think I'm good to push?

Thank you
-Hamlin
>
> -Alan



More information about the net-dev mailing list