RFR 8199437 [11]Improve diagnostic system assertion message in com.sun.net.httpserver impl
Daniel Fuchs
daniel.fuchs at oracle.com
Fri Mar 16 13:02:20 UTC 2018
Looks good Chris!
-- daniel
On 16/03/2018 12:54, Chris Hegarty wrote:
> On 14/03/18 15:48, Alan Bateman wrote:
>> On 14/03/2018 15:11, Chris Hegarty wrote:
>>> ...
>> I'm happy to include it in JDK-8199611 as that it doing several
>> cleanups in this area.
>
> With JDK-8199611 pushed, including SelectionKey::toString, the
> changes here reduce to simply:
>
> --- a/src/jdk.httpserver/share/classes/sun/net/httpserver/ServerImpl.java
> +++ b/src/jdk.httpserver/share/classes/sun/net/httpserver/ServerImpl.java
> @@ -407,7 +407,7 @@
> }
> handle (chan, conn);
> } else {
> - assert false;
> + assert false : "Unexpected
> non-readable key:" + key;
> }
> } catch (CancelledKeyException e) {
> handleException(key, null);
>
> -Chris.
More information about the net-dev
mailing list