RFR 8200181 [11] Remove superflous non-IPv4 code from Java_java_net_TwoStacksPlainSocketImpl_socketListen

[Ivan Gerasimov]

Hi Chris!

I was about to submit a patch for 8198358 that heavily modifies 
TwoStacksPlainSocketImpl to make it aligned with DualStackPlainSocketImpl.

That patch will also remove this problematic code.

I can rebase my patch, but wouldn't it be easier to proceed with that fix?

I'm going send the webrev set shortly.

With kind regards,

Ivan


On 3/23/18 10:18 AM, Chris Hegarty wrote:
> Given that JDK-8058965 removed the IPv6 support from
> TwoStacksPlainSocketImpl, the native socketListen method no longer
> needs to deal with the non-IPv4 code path. This simplifies the code,
> brings it in line with the unix variants, and removes a possible
> problematic code path that could close the socket without notifying
> the socket cleaner.
>
> http://cr.openjdk.java.net/~chegar/8200181.00/
> https://bugs.openjdk.java.net/browse/JDK-8200181
>
> -Chris.
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8058965
>

-- 
With kind regards,
Ivan Gerasimov