RFR [11] 8198358 : Align organization of DualStackPlainSocketImpl with TwoStacksPlainSocketImp [win]

Ivan Gerasimov ivan.gerasimov at oracle.com
Mon Mar 26 22:08:15 UTC 2018


Hello everyone!

A few modifications were done to the patch.
Below is the list of updated parts of the patch with comments about what 
has changed, comparing to the previous version of the patch.

The patched JDK builds fine and all the tests pass well.

WEBREV-000: http://cr.openjdk.java.net/~igerasim/8198358/04/000/webrev/
WEBREV-001: http://cr.openjdk.java.net/~igerasim/8198358/04/001/webrev/
WEBREV-002: http://cr.openjdk.java.net/~igerasim/8198358/04/002/webrev/
WEBREV-003: http://cr.openjdk.java.net/~igerasim/8198358/04/003/webrev/
- Rebased to reflect recent changes to socketListen()

WEBREV-004: http://cr.openjdk.java.net/~igerasim/8198358/04/004/webrev/
WEBREV-005: http://cr.openjdk.java.net/~igerasim/8198358/04/005/webrev/
WEBREV-006: http://cr.openjdk.java.net/~igerasim/8198358/04/006/webrev/
WEBREV-007: http://cr.openjdk.java.net/~igerasim/8198358/04/007/webrev/
WEBREV-008: http://cr.openjdk.java.net/~igerasim/8198358/04/008/webrev/
- The check the line 400 was changed to test if (newfd < 0) and then if 
(newfd == -2).
I don't think the later is quite accurate (cannot find in the 
documentation that accept can return -2), but it is how it was done in 
TwoStacks originally, so no regression is expected.

WEBREV-009: http://cr.openjdk.java.net/~igerasim/8198358/04/009/webrev/
- Added missing 'return -1;' at the line 188.

WEBREV-010: http://cr.openjdk.java.net/~igerasim/8198358/04/010/webrev/
WEBREV-011: http://cr.openjdk.java.net/~igerasim/8198358/04/011/webrev/
WEBREV-012: http://cr.openjdk.java.net/~igerasim/8198358/04/012/webrev/
WEBREV-013: http://cr.openjdk.java.net/~igerasim/8198358/04/013/webrev/
WEBREV-014: http://cr.openjdk.java.net/~igerasim/8198358/04/014/webrev/

With kind regards,
Ivan



More information about the net-dev mailing list